Preserve implicits in Quotes context #23263
Conversation
joroKr21
force-pushed
the
bugfix/quoted-implicits
branch
2 times, most recently
from
a32c7a2 to
47cd9ba
Compare
joroKr21
force-pushed
the
bugfix/quoted-implicits
branch
from
47cd9ba to
ccc5d1a
Compare
There was a problem hiding this comment.
This is a very good PR, thank you so much @joroKr21 for fixing this and signaling the issue, especially with that second minimisation. Since this is a big change I was worried if any regressions across the ecosystem would pop up, however the open community build did not seem to find anything, so I am mostly comfortable with merging. I do have one question about something.
Also apologies for taking a long time on this, I was unavailable until recently.
| else if info.isImplicitMethod then Implicit | SyntheticParam | ||
| else SyntheticParam | ||
| val params = info.paramNames.lazyZip(info.paramInfos).map: (pname, ptype) => | ||
| val flags = if ptype.hasAnnotation(defn.ErasedParamAnnot) then commonFlags | Erased else commonFlags |
There was a problem hiding this comment.
I can't figure this part out - adding erased flags to the param flags seems like it might a good change, but I don't see how it relates to the rest of the PR. Is it necessary? I tried running the compilation test without this and it seemed fine (I am only talking about the Erased flag here).
There was a problem hiding this comment.
The JS tests failed without it: https://github.com/scala/scala3/actions/runs/15238955325/job/42856571339 - I guess this was caused by the discrepancy of the parameter symbols in the tree vs those in the type signature. Which are now the same in this PR.
Fixes #22260